Skip to content

⬆️ Upgrades Mypy to 1.16.1 #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

⬆️ Upgrades Mypy to 1.16.1 #8006

merged 3 commits into from
Jul 3, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 30, 2025 •
edited
Loading

Autoscaling unit tests runs in <1 minute instead of 8-10 minutes

Highlights on updated libraries (only updated libraries are included)

  • #packages before ~ 9
  • #packages after ~ 3
# name before after upgrade count packages
1 annotated-types 0.7.0 🗑️ removed 1 celery-library🧪
2 fastapi 0.115.12 🗑️ removed 1 celery-library🧪
3 mypy 1.15.0 1.16.1 minor 49 agent🔧
api-server🧪🔧
autoscaling🔧
aws-library🔧
catalog🧪🔧
celery-library🔧
clusters-keeper🔧
common-library🔧
dask-sidecar🔧
dask-task-models-library🔧
datcore-adapter🔧
director-v2🧪🔧
director🔧
docker-api-proxy🔧
dynamic-scheduler🧪🔧
dynamic-sidecar🧪🔧
e2e-playwright🧪
efs-guardian🔧
invitations🔧
migration🧪🔧
models-library🔧
notifications-library🧪🔧
notifications🔧
payments🧪🔧
performance🧪
postgres-database🧪🔧
public-api🧪
resource-usage-tracker🧪🔧
service-integration🔧
service-library🧪🔧
settings-library🔧
simcore-sdk🧪🔧
storage🧪🔧
swarm-deploy🧪
web🧪🔧
4 mypy-extensions 1.0.0 1.1.0 minor 39 agent🔧
api-server🧪🔧
aws-library🔧
catalog🧪🔧
common-library🔧
datcore-adapter🔧
director🔧
docker-api-proxy🔧
dynamic-sidecar🧪🔧
e2e-playwright🧪
efs-guardian🔧
invitations🔧
migration🧪🔧
models-library🔧
notifications-library🧪🔧
notifications🔧
payments🧪🔧
postgres-database🧪🔧
public-api🧪
resource-usage-tracker🧪🔧
service-integration🔧
service-library🧪🔧
settings-library🔧
simcore-sdk🧪🔧
storage🧪🔧
swarm-deploy🧪
web🧪🔧
5 pydantic 2.11.4 🗑️ removed 1 celery-library🧪
6 pydantic-core 2.33.2 🗑️ removed 1 celery-library🧪
7 starlette 0.46.2 🗑️ removed 1 celery-library🧪
8 typing-inspection 0.4.0 🗑️ removed 1 celery-library🧪
9 ujson 5.10.0 🗑️ removed 1 storage⬆️

@sanderegg sanderegg added this to the Engage milestone Jun 30, 2025
@sanderegg sanderegg self-assigned this Jun 30, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (0a6eef0) to head (0909294).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8006      +/-   ##
==========================================
- Coverage   87.87%   87.35%   -0.52%     
==========================================
  Files        1853     1846       -7     
  Lines       71495    71305     -190     
  Branches     1258     1258              
==========================================
- Hits        62823    62286     -537     
- Misses       8308     8655     +347     
  Partials      364      364
Flag Coverage Δ
integrationtests 60.40% <83.33%> (-3.80%) ⬇️
unittests 86.52% <75.00%> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.15% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.27% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.19% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.62% <0.00%> (ø)
pkg_settings_library 90.64% <ø> (ø)
pkg_simcore_sdk 85.05% <ø> (-0.06%) ⬇️
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.21% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 85.43% <75.00%> (-5.57%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <100.00%> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.00% <ø> (-0.06%) ⬇️
storage 86.36% <100.00%> (ø)
webclient ∅ <ø> (∅)
webserver 87.68% <ø> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6eef0...0909294. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg requested a review from bisgaard-itis June 30, 2025 06:05
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 30, 2025
@sanderegg
Copy link
Member Author

sanderegg commented Jun 30, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = integration-tests
        • check-skipped = integration-tests
        • check-success = integration-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg requested a review from odeimaiz June 30, 2025 06:30
@pcrespov pcrespov changed the title ⬆️Mypy --> 1.16.1 ⬆️ Upgrades Mypy to 1.16.1 Jun 30, 2025
@sanderegg sanderegg force-pushed the maintenance/upgrade-mypy branch from aef15f9 to df77d61 Compare June 30, 2025 14:25
giancarloromeo
giancarloromeo approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

@sanderegg sanderegg force-pushed the maintenance/upgrade-mypy branch from df77d61 to 0909294 Compare July 3, 2025 05:57
@sanderegg
Copy link
Member Author

sanderegg commented Jul 3, 2025

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2025

requeue

☑️ This pull request is already queued

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit c6cacbd into ITISFoundation:master Jul 3, 2025
93 of 97 checks passed
@sanderegg sanderegg deleted the maintenance/upgrade-mypy branch July 3, 2025 06:34
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

6 participants

@sanderegg @giancarloromeo @pcrespov @odeimaiz @matusdrobuliak66 @bisgaard-itis